✨ Add CRD Upgrade Safety Preflight check to the ClusterExtension controller #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for olmv1 failed.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
- Coverage 79.40% 76.89% -2.51%
==========================================
Files 17 17
Lines 1170 1225 +55
==========================================
+ Hits 929 942 +13
- Misses 165 201 +36
- Partials 76 82 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rashmigottipati
force-pushed
the
enable-crd-upgrade-safety-checks
branch
3 times, most recently
from
de72c86 to
86634d8
Compare
rashmigottipati
force-pushed
the
enable-crd-upgrade-safety-checks
branch
from
af4db2b to
da48d55
Compare
everettraven
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Changes LGTM - thanks @rashmigottipati !
Would love to see a demo of this functioning in the next community call!
rashmigottipati
force-pushed
the
enable-crd-upgrade-safety-checks
branch
from
da48d55 to
d84277f
Compare
everettraven
previously approved these changes
Jun 27, 2024
rashmigottipati
force-pushed
the
enable-crd-upgrade-safety-checks
branch
from
d84277f to
7ac4221
Compare
…ller Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
rashmigottipati
force-pushed
the
enable-crd-upgrade-safety-checks
branch
from
7ac4221 to
06914d2
Compare
everettraven
approved these changes
Jun 27, 2024
Merged
via the queue into
operator-framework:main
with commit Jun 27, 2024
cab41aa
15 of 17 checks passed
4 tasks
4 tasks
This was referenced Jul 5, 2024
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
…roller (operator-framework#979) * Add CRD Upgrade Safety Preflight check to the ClusterExtension controller Signed-off-by: Rashmi Gottipati <[email protected]> * add nil pointer check Signed-off-by: Rashmi Gottipati <[email protected]> --------- Signed-off-by: Rashmi Gottipati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ClusterExtensioncontroller to be configured with preflight checks and run them if they're enabledFixes #877
Reviewer Checklist